mbutrovich commented on PR #4387: URL: https://github.com/apache/datafusion-comet/pull/4387#issuecomment-4511549675
> @mbutrovich Do you think this approach is still needed, or is the existing Spark UDF support just as good now? I'm not sure it's worth maintaining as an access path. _In theory_, if someone could adapt their UDF logic to be applied directly to Arrow types, then a user could elide a type change if they reimplemented as a `CometUDF` instead of programming against Spark UDF signature types. However, #4267 already codegens in optimizations like unsafe Arrow access (which users are unlikely to do), etc. So I think we're already in good shape from a performance standpoint. I also don't imagine users would want to maintain/debug both a `CometUDF` and the general `ScalaUDF` implementations when the former possibly provides minimal performance benefit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
