Jefffrey commented on PR #22387: URL: https://github.com/apache/datafusion/pull/22387#issuecomment-4517422036
I was more thinking along the lines of explicitly expecting from/to/max to be scalars in the scalar path, instead of allowing them to be both scalar and array and having those code paths within the fast path. I guess what I'm trying to get at, is what behaviour is this optimization targeting? Like is there a common query pattern that this accelerates (where only `from` is scalar but `to` and `max` may be non-scalar)? Knowing this would help us know which code paths to support (otherwise we might introduce a lot of complexity to handle a code path that rarely occurs in practice 🤔) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
