iffyio commented on code in PR #2346:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2346#discussion_r3288037738
##########
tests/sqlparser_hive.rs:
##########
@@ -562,6 +562,38 @@ fn test_tample_sample() {
hive().verified_stmt("SELECT * FROM source TABLESAMPLE (10 ROWS)");
}
+#[test]
+fn parse_create_table_with_map_column_comment() {
+ let sql = "create table tmp.xxx (kv_map map<string, string> comment 'kv
col comment');";
Review Comment:
I don't think we necessarily need to, the impl is ok if we're happy with the
current roundtrip behavior, my comment was primarily around the test setup, if
verified_stmt does not apply to the syntax then an alternative will be
`one_statement_parse_to` where we pass the input sql and expected canonical sql
to assert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
