0lai0 commented on code in PR #4364:
URL: https://github.com/apache/datafusion-comet/pull/4364#discussion_r3289506319
##########
spark/src/main/java/org/apache/comet/vector/CometPlainVector.java:
##########
@@ -33,6 +33,7 @@
/** A column vector whose elements are plainly decoded. */
public class CometPlainVector extends CometDecodedVector {
private final long valueBufferAddress;
+ private final long offsetBufferAddress;
private final boolean isBaseFixedWidthVector;
Review Comment:
I think using an enum would be cleaner than maintaining a growing set of
booleans. I'm not sure if I should include this refactor in the current patch
or open a separate issue to track it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
