jayshrivastava commented on code in PR #22452:
URL: https://github.com/apache/datafusion/pull/22452#discussion_r3290161659
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -419,6 +419,112 @@ impl DynamicFilterPhysicalExpr {
}
}
+#[cfg(feature = "proto")]
+impl DynamicFilterPhysicalExpr {
+ /// Serialize this expression to protobuf.
+ ///
+ /// Encodes `children`, `remapped_children`, and the atomically-captured
+ /// `Inner` state (expression id, generation, current expr, is_complete).
+ pub fn try_to_proto(
Review Comment:
I don't think this path is being used. I think it needs to move to the `impl
PhysicalExpr` block to override the default `PhysicalExpr::try_to_proto`
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
