gstvg commented on code in PR #22362:
URL: https://github.com/apache/datafusion/pull/22362#discussion_r3291605521
##########
datafusion/proto/src/logical_plan/to_proto.rs:
##########
@@ -634,11 +635,35 @@ pub fn serialize_expr(
.unwrap_or(HashMap::new()),
})),
},
- Expr::HigherOrderFunction(_) | Expr::Lambda(_) |
Expr::LambdaVariable(_) => {
- return Err(Error::General(
- "Proto serialization error: Lambda not
implemented".to_string(),
- ));
+ Expr::HigherOrderFunction(HigherOrderFunction { func, args }) => {
Review Comment:
Much easier to cross check the impls now
https://github.com/apache/datafusion/pull/22362/changes/5688f3f79de2a71f0d73ad09e1158527aeae659a
thanks
(also did this to others similar matchs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
