kosiew commented on code in PR #22444: URL: https://github.com/apache/datafusion/pull/22444#discussion_r3292535719
########## datafusion/sqllogictest/test_files/eliminate_outer_join.slt: ########## @@ -370,6 +370,25 @@ select * from t1 left join t2 on t1.a = t2.x where (t2.y > 150) is unknown; 3 30 c NULL NULL NULL NULL 40 d NULL NULL NULL +# LEFT JOIN + WHERE NOT ((t2.y > 150) IS TRUE) -> stays LEFT JOIN Review Comment: Nice addition to the SLT coverage. Right now the end-to-end regression only exercises `NOT ((...) IS TRUE)`. The optimizer unit tests also cover `NOT IS FALSE` and `NOT IS NOT UNKNOWN`, and those seem worth checking through SQL execution as well. Would you consider adding matching SLT cases for those two forms too? That would help verify both the optimized plan shape and the returned LEFT-padded rows for the full set of SQL-visible variants. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
