Rachelint commented on PR #11750: URL: https://github.com/apache/datafusion/pull/11750#issuecomment-2260946831
> > Actually, I am thinking that, maybe exist a threshold (like xx% of the bucket have been filled), and it is just reasonable to check the hash first when exceed it. > > It might be worth checking -- one thing that we have to be careful of is that the overhead of the check itself may end up large Make sense, will make more experiments about this when having free time. Another thing I found maybe we can optimize is about the `group index`. We use `usize` type now, it seems too big(which lead to the large size of hash table), maybe u32 is enough? Actually u32 can hold `42 * (sizeof T) G` entries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
