geoffreyclaude commented on PR #19390: URL: https://github.com/apache/datafusion/pull/19390#issuecomment-4552711823
@adriangb Sorry for the late reply, I was off and somehow missed this notification. I agree that this change is pretty well tested and benchmarked now, so I'd be pretty surprised if it introduces major issues (we might still have some weird edge case of course, as usual.) What I'm a bit more concerned about is maintainability as it does introduce quite a bit of complex features. In particular, "Commit 7: Implement Direct Probe", while showing significant gains, is pretty tricky to understand well. I would never have come up with something like this without AI "helping" out. WDYT? Are the performance gains worth the additional future headaches when new work in this area is needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
