viirya commented on code in PR #736:
URL: https://github.com/apache/datafusion-comet/pull/736#discussion_r1699001341
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -1599,6 +1599,18 @@ impl PhysicalPlanner {
}
}
+ /// Find DataFusion's built-in window function by name.
+ fn find_df_window_function(name: &str) -> Option<WindowFunctionDefinition>
{
+ if let Some(f) = find_df_window_func(name) {
+ Some(f)
+ } else {
+ match name {
+ "count" =>
Some(WindowFunctionDefinition::AggregateUDF(count_udaf())),
+ _ => None,
Review Comment:
Can we look for aggregate udf from FunctionRegistry? It is similar to how we
look for scalar function from `FunctionRegistry`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
