alamb commented on issue #22506: URL: https://github.com/apache/datafusion/issues/22506#issuecomment-4556933958
> [@alamb](https://github.com/alamb) would it make sense to use comparison_coercion in get_parameter_fields() when merging placeholder types, instead of strict equality? That would unify cases like Utf8 + Utf8View → Utf8View, matching what normal queries already do at comparison sites, while still erroring on truly incompatible types. Yes @RatulDawar -- applying the same coercion logic sounds right to me I am not sure if `comparison_coercion` is the right function though -- I vaguely remember that there was special code that tried to determine the type of a placeholder (which isn't known, and isn't the same as type coercsion) -- it might be good to investigate why the behavior is different in the cases above before trying to code up some fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
