martin-g commented on code in PR #1742:
URL:
https://github.com/apache/datafusion-ballista/pull/1742#discussion_r3313388536
##########
ci/scripts/rust_clippy.sh:
##########
@@ -18,4 +18,11 @@
# under the License.
set -ex
-cargo clippy --all-targets --workspace --all-features -- -D warnings
+cargo clippy --all-targets --package ballista-core --all-features -- -D
warnings
+cargo clippy --all-targets --package ballista-scheduler --all-features -- -D
warnings
+cargo clippy --all-targets --package ballista-executor --all-features -- -D
warnings
+cargo clippy --all-targets --package ballista --all-features -- -D warnings
+cargo clippy --all-targets --package ballista-cli --no-default-features
--features cli,tui -- -D warnings
+#cargo clippy --all-targets --package ballista-cli --no-default-features
--features web -- -D warnings
+cargo clippy --all-targets --package ballista-examples --all-features -- -D
warnings
Review Comment:
It seems running clippy on ballista-examples crate concretely exposes some
problems:
```
error[E0432]: unresolved import `ballista_core::object_store`
--> examples/examples/custom-client.rs:19:20
|
19 | use ballista_core::object_store::state_with_s3_support;
| ^^^^^^^^^^^^ could not find `object_store` in
`ballista_core`
```
For some reason those are not reported when running Clippy on the whole
workspace (line 21).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
