milenkovicm commented on code in PR #1778:
URL:
https://github.com/apache/datafusion-ballista/pull/1778#discussion_r3313882292
##########
ballista/scheduler/src/api/handlers.rs:
##########
@@ -382,16 +395,17 @@ pub async fn get_job<
let percent_complete =
((completed_stages as f32 / num_stages as f32) * 100_f32) as u8;
- let render_tree = query.render_tree.unwrap_or(false);
+ let plan_format = query.plan_format.clone().unwrap_or(PlanFormat::Default);
Review Comment:
Is there unwrap or default method ?
##########
ballista/scheduler/src/api/handlers.rs:
##########
@@ -490,7 +504,7 @@ pub async fn get_query_stages<
Path(job_id): Path<String>,
query: Query<JobQueryParams>,
) -> Result<impl IntoResponse, SchedulerErrorResponse> {
- let render_tree = query.render_tree.unwrap_or(false);
+ let plan_format = query.plan_format.clone().unwrap_or(PlanFormat::Default);
Review Comment:
Unwrap or default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
