Sean-Kenneth-Doherty commented on PR #22291: URL: https://github.com/apache/datafusion/pull/22291#issuecomment-4559054471
Updated in `57df3fbb9` to use `saturating_sub(1)` for `start_from` normalization, matching the existing later bounds-validation flow. I also changed the regression to exercise the full `array_position` path for a non-null row with `i64::MIN`, so the important behavior remains covered: no arithmetic panic, just a normal `start_from out of bounds` error. Validation: - `cargo fmt --all --check` - `git diff --check` - `CARGO_BUILD_JOBS=2 cargo test -p datafusion-functions-nested position::tests::test_array_position_start_from_min_value -- --nocapture` - `CARGO_BUILD_JOBS=2 cargo test -p datafusion-sqllogictest --test sqllogictests -- array/array_position.slt` (`1/1 files completed`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
