timsaucer commented on PR #1527: URL: https://github.com/apache/datafusion-python/pull/1527#issuecomment-4559573909
I don't think this PR closes the linked issue. Also it states that these arguments are not documented but my read of each one does include documentation of what the variables are. They are not laid out in an `Args:` section but these are also nearly one line argument descriptions. This PR seems more pedantic than adding significant value. @BharatDeva can you expand a little on why you think the existing documentation is insufficient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
