andygrove opened a new pull request, #4479: URL: https://github.com/apache/datafusion-comet/pull/4479
## Which issue does this PR close? Closes #. ## Rationale for this change Continuation of the per-category expression audit. Same pattern as #4478 (map), #4476 (hash), #4475 (conditional), #4474 (misc), #4473 (collection), #4470 (json), #4469 (struct), using the updated `audit-comet-expression` skill in #4468. ## What changes are included in this PR? ### Support-doc audit notes Add per-version audit sub-bullets to all 11 supported bitwise SQL function names (`&`, `<<`, `>>`, `^`, `bit_count`, `bit_get`, `getbit`, `shiftright`, `shiftrightunsigned`, `|`, `~`). The Spark expression classes are byte-for-byte identical across the four versions for behaviour; the only changes are the parser-level operator aliases added in Spark 4.0 (`<<` / `>>` / `>>>` as aliases for `shiftleft`/`shiftright`/`shiftrightunsigned`) and the new `BitShiftOperation` shared base trait. `getbit` is a registry alias of `BitwiseGet` / `bit_get`. ### Support-level consistency fixes None. The seven backing serdes were already clean. `CometShiftLeft` and `CometShiftRight` already correctly cast the `right` operand to `LongType` when needed for DataFusion's matching-operand-type requirement. ### Tracking issues filed for follow-up None. ### Audit process Audited directly using the `audit-comet-expression` skill (4 Spark versions per #4468). Seven backing serdes, no parallel subagents needed. ## How are these changes tested? - `make core` succeeds (no code changes; doc only). - Existing `CometBitwiseExpressionSuite` coverage remains unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
