koopatroopa787 commented on code in PR #22636:
URL: https://github.com/apache/datafusion/pull/22636#discussion_r3337671784
##########
datafusion/physical-expr/src/expressions/literal.rs:
##########
@@ -190,3 +225,93 @@ mod tests {
Ok(())
}
}
+
+/// Tests for the `try_to_proto` / `try_from_proto` hooks.
+#[cfg(all(test, feature = "proto"))]
+mod proto_tests {
+ use super::*;
+ use crate::proto_test_util::{StubEncoder, UnreachableDecoder, column_node};
+ use datafusion_common::DataFusionError;
+ use
datafusion_physical_expr_common::physical_expr::proto_decode::PhysicalExprDecodeCtx;
+ use
datafusion_physical_expr_common::physical_expr::proto_encode::PhysicalExprEncodeCtx;
+ use datafusion_proto_models::protobuf::physical_expr_node;
+
+ fn i32_literal() -> Literal {
+ Literal::new(ScalarValue::Int32(Some(42)))
+ }
+
+ // ── try_to_proto
─────────────────────────────────────────────────────────
+
+ #[test]
+ fn try_to_proto_encodes_literal() {
+ let literal = i32_literal();
+ let encoder = StubEncoder::ok();
+ let ctx = PhysicalExprEncodeCtx::new(&encoder);
+
+ let node = literal
+ .try_to_proto(&ctx)
+ .unwrap()
+ .expect("Literal should encode to Some(node)");
+
+ // Literal nodes never set expr_id.
+ assert!(node.expr_id.is_none());
+ // Variant must be Literal, not any other expr type.
+ assert!(matches!(
+ node.expr_type,
+ Some(physical_expr_node::ExprType::Literal(_))
+ ));
+ }
+
+ #[test]
+ fn try_to_proto_null_literal() {
+ let literal = Literal::new(ScalarValue::Int32(None));
+ let encoder = StubEncoder::ok();
+ let ctx = PhysicalExprEncodeCtx::new(&encoder);
+
+ let node = literal
+ .try_to_proto(&ctx)
+ .unwrap()
+ .expect("null Literal should encode to Some(node)");
+
+ assert!(matches!(
Review Comment:
Good call, done! The test now decodes the proto node and asserts
`lit.value() == &ScalarValue::Int32(None)` to verify the null payload
round-trips correctly, not just the variant tag. Fix is in the latest commit
(338c0a5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
