theirix commented on PR #22244: URL: https://github.com/apache/datafusion/pull/22244#issuecomment-4617583112
> I'm a bit lost on this PR now; it seems we're also changing the `||` operator in addition? Did we change what desired behaviour we want? Sorry, the logic changed after the initial submission. The PR description reflects the actual logic. Yes, UDFs and the pipe operator should be in sync. The previous PR #21883 disallows mixed string-binary concatenation, which is wrong, as you've shown above. I am enabling coercion for mixed concatenation of UDFs and the pipe operator - it is consistent now. If it is merged, no breaking changes are included in the release - cc @alamb . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
