sweb commented on PR #22628: URL: https://github.com/apache/datafusion/pull/22628#issuecomment-4634638639
> @sweb > > Thanks for working on this. I think there are still a couple of important semantic gaps around float equality and hashing that should be tightened up before this lands. > > The core SQL invariant may still be incomplete outside the touched comparison/`IN` paths. Float hashing in DataFusion uses raw float bits, so `+0.0` and `-0.0` can hash differently in hash-based equality contexts such as joins, grouping, or DISTINCT-style paths. If this PR intentionally scopes the fix to scalar comparisons and `IN`, please say so explicitly and add/track follow-up coverage for the remaining SQL equality contexts; otherwise this should be fixed/tested as part of the same semantic change. thank you for your review! I'll work on improving it in the next days! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
