devoopsman45 commented on PR #102: URL: https://github.com/apache/datafusion-java/pull/102#issuecomment-4638801082
> @coderfender Can you please review? > Thank you @devoopsman45 , left some comments. Also, is a noop standard across df bindings when a table does not exist? Yes, Datafusion Rust API deregister_table returns Result<Option<...>> i.e. it is returning an Option indicating it is designed to be idempotent. Hence, on the Java side, treating it as no-op makes sense. Please let me know your thoughts. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
