2010YOUY01 commented on PR #22791:
URL: https://github.com/apache/datafusion/pull/22791#issuecomment-4641127455
Thank you for the great explanation and fix!
I assume this bug has not been caught by the current test? Let's add the bug
reproducer to `sqllogictest`, then it should be good to go.
One optional clean-up idea we can do as follow-up:
```
now:
FetchingRight -> EliminateLeftUnmatched
refactor idea:
FetchingRight -> ProbeEnd -> EliminateLeftUnmatched
```
It seems `EliminateLeftUnmatched` now is doing both 1. check if current
partition should do the emit left job 2. maybe do emit left.
So its inner logic become hard to follow and caused a bug, splitting might
make it clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
