Amogh-2404 opened a new pull request, #22797:
URL: https://github.com/apache/datafusion/pull/22797

   ## Which issue does this close?
   
   Part of #22330.
   
   ## Rationale for this change
   
   `FFI_ScalarUDF` doesn't plumb `with_updated_config`, so a provider that 
overrides it has the override silently dropped across the FFI boundary — the 
consumer falls back to the trait default (`None`). Continues the 
method-coverage work started with `placement` (#22608).
   
   ## What changes are included in this PR?
   
   - Adds a `with_updated_config` fn pointer to `FFI_ScalarUDF` plus the 
wrapper and forwarding on both sides. Config crosses in via the existing 
`FFI_ConfigOptions`; the reconfigured UDF comes back as 
`FFI_Option<FFI_ScalarUDF>`.
   - A forced-foreign unit test and a cross-cdylib integration test, both 
asserting the override survives the boundary.
   
   Adding the field changes the `#[repr(C)]` layout, so this is an ABI change.
   
   ## Are these changes tested?
   
   Yes — `cargo test -p datafusion-ffi --features integration-tests`.
   
   ## Are there any user-facing changes?
   
   ABI change for FFI consumers (recompile required). No SQL-level changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to