Nagato-Yuzuru opened a new issue, #22806: URL: https://github.com/apache/datafusion/issues/22806
Follow-up from #22702 ## Problem After #22702 adds `fill_nan`, the two sibling methods diverge: ```rust pub fn fill_null(&self, value: ScalarValue, columns: Vec<String>) -> Result<DataFrame> pub fn fill_nan (&self, value: ScalarValue, columns: &[&str]) -> Result<DataFrame> ``` `fill_nan` uses the ergonomic `&[&str]`; fill_null still uses `Vec<String>` (public since 2025-02). Callers write vec!["a".to_owned()] for one and &["a"] for the other. ## Proposed Converge on one convention `&[&str]` Breaking change to fill_null. Needs an upgrade guide entry, and decide a breaking change or deprecate and add. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
