Nagato-Yuzuru commented on issue #22806: URL: https://github.com/apache/datafusion/issues/22806#issuecomment-4646362096
Hi, @Jefffrey @kosiew . Will do this as a breaking change to `fill_null` (Vec<String> → &[&str] and ScalarValue -> &ScalarValue) with an upgrade-guide note, targeting the same release as `fill_nan`. Or we deprecate and add a new method with the aligned signature? I lean toward A (cleaner, and the name's already taken so deprecation needs a new name), but happy to go with B. Which do you prefer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
