nathanb9 opened a new issue, #22808:
URL: https://github.com/apache/datafusion/issues/22808

   ### Is your feature request related to a problem or challenge?
   
   Follow-up to https://github.com/apache/datafusion/pull/22791
   From @2010YOUY01's comment to clean up state splitting:
   ```
   now:      FetchingRight -> EmitLeftUnmatched
   proposed: FetchingRight -> ProbeEnd -> EmitLeftUnmatched
   ```
   `EmitLeftUnmatched` currently both decides whether this partition emits 
unmatched-left rows (decrementing the shared probe counter) and does the 
emitting. Re-entry of that state caused the double-decrement bug fixed in 
https://github.com/apache/datafusion/pull/22791. A dedicated `ProbeEnd` state 
(entered once per chunk/partition when the right side is exhausted) would own 
the single `report_probe_completed()` call, making "decrement exactly once" a 
property of the state graph and removing the `probe_completed_reported` flag 
added in [#22791](https://github.com/apache/datafusion/pull/22791). No behavior 
change expected.
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to