kumarUjjawal commented on PR #21765:
URL: https://github.com/apache/datafusion/pull/21765#issuecomment-4646029425
@Rich-T-kid Left some comments, I was also thinking we should add some tests
like
- test for de-duplicating the same value across two batches with different
value buffers
- coverage of the string-view value type
- end-to-end SQL test
- test for the streaming/ordered emit path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
