Rich-T-kid commented on PR #21765: URL: https://github.com/apache/datafusion/pull/21765#issuecomment-4649570634
@kumarUjjawal for the E2E sql test there are already a couple that exist for dictionary so I just added one more that uses StringViews as a value type. As for streaming, I assume you were referring to the partial emit that datafusion uses for spills to disk? I added a [test](https://github.com/apache/datafusion/pull/21765/changes#diff-4515126fc8522ddcc05a5673023bf83367b0c21e31f2933e792d42da8f2d6a63R838) that validates the original group ID is correct across partial emits. let me know if you were referring to something else & I can add a test for that as well! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
