jayzhan211 commented on code in PR #11724:
URL: https://github.com/apache/datafusion/pull/11724#discussion_r1702805664
##########
datafusion/common/src/column.rs:
##########
@@ -156,6 +157,17 @@ impl Column {
}
}
+ fn quoted_flat_name_if_contain_dot(&self) -> String {
+ match &self.relation {
+ Some(r) => format!(
+ "{}.{}",
+ table_reference_to_quoted_string(r),
+ quoted_if_contain_dot(&self.name)
+ ),
+ None => quoted_if_contain_dot(&self.name).to_string(),
+ }
+ }
Review Comment:
I think it is not ideal if `sum(t1.c1)` is quoted 🤔 . I hope the change is
as small as possible, so I would prefer to keep function or others Expr remain
the same, only identifier with dot is quoted.
We could also hold on and wait for more input from other's about the change
of this, given the change of this is not trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
