coderfender commented on code in PR #1875:
URL:
https://github.com/apache/datafusion-ballista/pull/1875#discussion_r3429473311
##########
ballista/core/src/serde/scheduler/from_proto.rs:
##########
@@ -108,14 +108,19 @@ impl TryInto<PartitionLocation> for
protobuf::PartitionLocation {
)
})?
.into(),
- executor_meta: self
- .executor_meta
- .ok_or_else(|| {
+ partition_location_metadata: {
+ let m = self.executor_meta.ok_or_else(|| {
BallistaError::General(
"executor_meta in PartitionLocation is
missing".to_owned(),
)
- })?
- .into(),
+ })?;
+ Arc::new(PartitionLocationMetadata {
Review Comment:
Would it be okay to create a followup PR to handle the second part and port
all common info in `ShuffleReaderExec` proto level and not `PartitionLocation` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
