wugeer commented on code in PR #2340:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2340#discussion_r3434841837
##########
src/ast/mod.rs:
##########
@@ -2267,12 +2267,58 @@ pub struct WindowSpec {
pub window_name: Option<Ident>,
/// `OVER (PARTITION BY ...)`
pub partition_by: Vec<Expr>,
+ /// The kind of partitioning clause used in the window specification.
+ pub partition_by_kind: WindowPartitionByKind,
Review Comment:
This is a good idea, but the change is very disruptive. Wouldn't it be
better to open a separate PR for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
