RatulDawar commented on PR #22857: URL: https://github.com/apache/datafusion/pull/22857#issuecomment-4752976129
Addressed all review feedback in the latest commits: - **Cached reader path**: `CachedParquetFileReader::get_metadata` forwards `PageIndexPolicy` from `ArrowReaderOptions` into `DFParquetMetadata::fetch_metadata`. - **Regression tests**: assert `page_index_load_skipped` metric (and cached footer-only metadata for the cached-reader test). - **`should_load_page_index`**: uses `is_some_and` + `any`. - **Semver**: `page_index_load_skipped` is recorded via `pub(crate) add_page_index_load_skipped`, not a new public field on `ParquetFileMetrics`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
