CuteChuanChuan commented on PR #22473: URL: https://github.com/apache/datafusion/pull/22473#issuecomment-4762315286
Hi @comphead , could you PTAL when you have a chance? Following up on the downstream-naming question: I added an ArraysZip::with_field_names constructor to datafusion-functions-nested so the Spark wrapper injects the resolved field names instead of rebuilding the List<Struct> to rename it. This lets the spark crate keep only the Spark-specific logic (name policy + the analyzer rewrite) and reuse the native implementation for everything else — the zip itself, and applying the names. For downstream projects using arrays_zip directly: the native functions-nested function defaults to ordinal field names and now also accepts custom names via with_field_names; the Spark-faithful naming (column names 0-based ordinals) lives in the spark crate and relies on the registered rewrite rule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
