getChan commented on code in PR #4647:
URL: https://github.com/apache/datafusion-comet/pull/4647#discussion_r3448602964
##########
spark/src/main/scala/org/apache/comet/codegen/CometBatchKernelCodegenInput.scala:
##########
@@ -672,6 +673,8 @@ private[codegen] object CometBatchKernelCodegenInput {
if (elementNullable) " if (isNullAt(i)) return null;\n"
Review Comment:
This is intentional. `NullType` has no typed getter to override (there is no
`getNull` API), so we emit no scalar getter here. Null semantics are handled
via `isNullAt` (always true for `NullVector`) and generic `get(..., NullType)`
dispatch, which returns `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
