alamb opened a new pull request, #11825:
URL: https://github.com/apache/datafusion/pull/11825

   ## Which issue does this PR close?
   
   Draft:
   - [ ] Builds on https://github.com/apache/datafusion/pull/11734
   - [ ] Run end to end benchmarks
   - [ ] Run `cargo bench` benchmarks
   
   
   ## Rationale for this change
   
   * Follow on #11627 from @korowa
   * I created a function that manipulates the null mask and filters in 
https://github.com/apache/datafusion/pull/11734 which I think can be used to 
reduce duplication  (and possibly might be faster) in `convert_to_state`
   
   ## What changes are included in this PR?
   
   Use the `filtered_null_mask` and `set_nulls` functions introduced in 
https://github.com/apache/datafusion/pull/11734 in 
   *  `CountGroupsAccumulator `
   * `PrimitiveGroupsAccumulator`
   
   
   ## Are these changes tested?
   functionally by CI
   
   Perormance benchmarks: in progress
   
   
   ## Are there any user-facing changes?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to