Dodothereal opened a new pull request, #23129: URL: https://github.com/apache/datafusion/pull/23129
## Summary Removes the free function `datafusion_datasource::write::create_writer`, which was deprecated in 48.0.0 with the suggestion to use `ObjectWriterBuilder::new(...)` instead. Per the [API health deprecation guidelines](https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines), APIs deprecated in 48.0.0 or earlier are now eligible for removal. A grep across the workspace confirms `create_writer` has **zero callers** anywhere in the repo (the other matches are differently-named methods `create_writer_physical_plan` and `create_writer_props`, which we are not touching) and is not re-exported from `datafusion_datasource::lib`. This is the smallest possible pure-removal cleanup — 16 lines deleted from a single file. Closes #23080 (partial — one of the listed eligible items). ## Test plan ``` git diff upstream/main..chore/remove-deprecated-create-writer datafusion/datasource/src/write/mod.rs | 16 ---------------- 1 file changed, 16 deletions(-) ``` Since all callers are gone, no test updates are needed; the standard CI matrix (`./dev/rust_lint.sh`, `cargo check -p datafusion-datasource`, downstream consumer builds) will catch any indirect breakage. ## AI assistance Used an AI coding assistant to identify and minimally remove the unused deprecated function. I read the file end-to-end before and after the diff, verified zero callers via a workspace grep, and the change is a 16-line pure deletion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
