Dodothereal commented on PR #23134: URL: https://github.com/apache/datafusion/pull/23134#issuecomment-4813305034
Rebased onto upstream/main (was at ab9dd4e; now at ab1b91e) to retrigger semver-checks against current main — and the **Check semver** job now **passes**: cargo-semver-checks' earlier `function_missing` warning against `add_row_stats` was, as suspected, an artifact of the CI's checkout of an older main where `with_output_partitioning` had been removed by the partitioning PR (#22657) and the comparison logic flagged unrelated fields. New run on current main proves zero semver impact: `add_row_stats` was the only freely-exported fn being removed and it has zero callers (verified again now). Also picked up a small `cargo fmt` regression. Ready for re-review when maintainer bandwidth allows; happy to re-push and/or close if `add_row_stats` needs a major-version bump instead. (Per the 24h engagement groove: this comment is *one* bump for *new information* — semver status — and not a generic ping.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
