Dandandan commented on code in PR #1900:
URL:
https://github.com/apache/datafusion-ballista/pull/1900#discussion_r3488478444
##########
ballista/core/src/extension.rs:
##########
@@ -760,18 +760,15 @@ impl SessionConfigHelperExt for SessionConfig {
// same like previous comment
.set_bool("datafusion.sql_parser.map_string_types_to_utf8view",
false)
//
- // As mentioned in
https://github.com/apache/datafusion-ballista/issues/1055
- // "Left/full outer join incorrect for CollectLeft / broadcast"
- //
- // In order to make correct results (decreasing performance)
CollectLeft
- // has been disabled until fixed
+ // A build side smaller than these thresholds is collected into a
+ // CollectLeft (broadcast) hash join rather than being
repartitioned.
.set_u64(
"datafusion.optimizer.hash_join_single_partition_threshold",
- 0,
+ 10 * 1024 * 1024,
Review Comment:
It probably needs some test cases for those ("duplicated unmatched keys
across executors") to make sure they don't regress and then see if we finally
solve it / bring it back? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
