andygrove commented on issue #3509: URL: https://github.com/apache/datafusion-comet/issues/3509#issuecomment-4844781244
Resolved. The buggy `can_cast_from_boolean` gate in the native `cast_supported` chain (which matched `(Boolean, _)` before `(_, Utf8)` and so rejected boolean → string) was removed as dead code in #3513. Cast-support decisions now live in `CometCast.scala`, where `isSupported` matches `(_, StringType)` before `(BooleanType, _)`, routing boolean → string to `canCastToString`, which returns `Compatible()` for booleans and recurses into struct fields for the complex-type-to-string path. Coverage exists in both layers: the native `test_bool_to_string_cast` unit test and the `cast BooleanType to StringType` test in `CometCastSuite`. Closing as resolved. Please reopen if you can still reproduce on a recent build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
