github-actions[bot] commented on PR #23274: URL: https://github.com/apache/datafusion/pull/23274#issuecomment-4850978231
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr-common v54.0.0 (current) Built [ 34.208s] (current) Parsing datafusion-expr-common v54.0.0 (current) Parsed [ 0.019s] (current) Building datafusion-expr-common v54.0.0 (baseline) Built [ 20.401s] (baseline) Parsing datafusion-expr-common v54.0.0 (baseline) Parsed [ 0.018s] (baseline) Checking datafusion-expr-common v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.199s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/enum_variant_added.ron Failed in: variant EmitTo:FirstBlock in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/groups_accumulator.rs:40 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 55.618s] datafusion-expr-common Building datafusion-functions-aggregate v54.0.0 (current) Built [ 32.291s] (current) Parsing datafusion-functions-aggregate v54.0.0 (current) Parsed [ 0.047s] (current) Building datafusion-functions-aggregate v54.0.0 (baseline) Built [ 32.116s] (baseline) Parsing datafusion-functions-aggregate v54.0.0 (baseline) Parsed [ 0.047s] (baseline) Checking datafusion-functions-aggregate v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.180s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 66.005s] datafusion-functions-aggregate Building datafusion-functions-aggregate-common v54.0.0 (current) Built [ 21.570s] (current) Parsing datafusion-functions-aggregate-common v54.0.0 (current) Parsed [ 0.019s] (current) Building datafusion-functions-aggregate-common v54.0.0 (baseline) Built [ 21.042s] (baseline) Parsing datafusion-functions-aggregate-common v54.0.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-functions-aggregate-common v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.131s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 44.041s] datafusion-functions-aggregate-common Building datafusion-physical-plan v54.0.0 (current) Built [ 37.682s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.132s] (current) Building datafusion-physical-plan v54.0.0 (baseline) Built [ 36.006s] (baseline) Parsing datafusion-physical-plan v54.0.0 (baseline) Parsed [ 0.128s] (baseline) Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.598s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure auto_trait_impl_removed: auto trait no longer implemented --- Description: A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented. ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/auto_trait_impl_removed.ron Failed in: type PrimitiveGroupValueBuilder is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/primitive.rs:46 type PrimitiveGroupValueBuilder is no longer RefUnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/primitive.rs:46 type ByteViewGroupValueBuilder is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/bytes_view.rs:43 type ByteViewGroupValueBuilder is no longer RefUnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/bytes_view.rs:43 --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_added.ron Failed in: trait method datafusion_physical_plan::aggregates::group_values::multi_group_by::GroupColumn::slice_n in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:107 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 75.687s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
