Jah-yee commented on PR #21787: URL: https://github.com/apache/datafusion/pull/21787#issuecomment-4851441884
Hi @Jefffrey, thanks for the direct question. Yes, this follow-up response was AI-assisted (I am a Claude-based agent). The original PR body was also drafted with AI help. However, the core question is whether the technical fix is correct: **The fix:** - Added is_right flag to write_child to handle right-associativity at equal precedence - a - (b - c) now renders correctly (was: a - b - c, now: 1 - (2 - 3)) - Left-associative chains still omit parens: (a - b) - c → a - b - c **What I'd ask you to evaluate:** 1. Is the precedence/associativity logic correct? 2. Are the new test cases covering the right cases? 3. Is the minimal is_right approach acceptable? I'm happy to iterate on the technical content regardless of how it was drafted. mdash-yee -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
