alamb commented on code in PR #23066:
URL: https://github.com/apache/datafusion/pull/23066#discussion_r3520437945
##########
datafusion/execution/src/runtime_env.rs:
##########
@@ -516,15 +548,17 @@ impl RuntimeEnvBuilder {
/// Returns a list of all available runtime configurations with their
current values and descriptions
pub fn entries(&self) -> Vec<ConfigEntry> {
- create_runtime_config_entries(
- None,
- Some("100G".to_string()),
- None,
- Some("50M".to_owned()),
- Some("1M".to_owned()),
- None,
- Some("20M".to_owned()),
- )
+ RuntimeConfigValues {
Review Comment:
this is a nice refactoring into a struct rather than a function
##########
datafusion/execution/src/runtime_env.rs:
##########
@@ -90,57 +90,77 @@ impl Debug for RuntimeEnv {
}
}
-/// Creates runtime configuration entries with the provided values
-///
-/// This helper function defines the structure and metadata for all runtime
configuration
-/// entries to avoid duplication between `RuntimeEnv::config_entries()` and
-/// `RuntimeEnvBuilder::entries()`.
-fn create_runtime_config_entries(
+struct RuntimeConfigValues {
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
