zhuqi-lucas commented on PR #186: URL: https://github.com/apache/datafusion-site/pull/186#issuecomment-4880849259
Thanks @alamb for the very detailed review — hugely appreciated. I've addressed each of the 31 inline comments individually (see the reply threads). **Summary of the pass:** - **Concision**: `839 → 627 lines` (~25% shorter). Killed the TL;DR block, cut implementation-detail paragraphs, and trimmed the phase-landing narrative. - **Reframed as a general DB technique**: opening is now **problem (partial sortedness / data lakes) → techniques (three complementary approaches) → results**, rather than the phase-by-phase "what we did" narrative. - **Motivation**: added the Iceberg / data-as-written point up front, plus the stats-for-sort-vs-stats-for-filter contrast. - **Trivial → exact**: renamed throughout, linked to @akurmustafa's [ordering-analysis blog](https://datafusion.apache.org/blog/2025/03/11/ordering-analysis/) as background. - **Links**: added inline links to `FileScanConfig`, `SortExec`, `SortPreservingMergeExec`, `BufferExec`, `FilePruner`, `PushdownSort` (docs.rs / GitHub source). - **Pelican link-rendering issue**: converted all nine `` [`X`][ref] `` patterns to inline `` [`X`](url) `` so the code-in-link renders correctly. - **Figures**: added `*Figure: ...*` captions under every diagram for skim-readability. - **Exemplar query**: added the `ORDER BY ts DESC LIMIT 10` trades example when introducing Exact / Inexact runtime behaviour. Ready for another pass whenever you have time. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
