Jefffrey commented on code in PR #23382: URL: https://github.com/apache/datafusion/pull/23382#discussion_r3541434111
########## datafusion/sqllogictest/test_files/array/array_prepend.slt: ########## @@ -57,7 +57,6 @@ select array_prepend(null, [[1,2,3]]); # DuckDB: [[]] # ClickHouse: [[]] -# TODO: We may also return [[]] Review Comment: seems we already return this ########## datafusion/sqllogictest/test_files/ddl.slt: ########## @@ -200,10 +200,6 @@ SELECT foo_schema.bar.a FROM foo_schema.bar; ---- 1 -# TODO: Drop schema for cleanup, see #6027 -# statement ok -# DROP SCHEMA foo_schema; Review Comment: tested later in the file now https://github.com/apache/datafusion/blob/f34a676302e2320526172705503a5ac8222804ea/datafusion/sqllogictest/test_files/ddl.slt#L772-L776 ########## datafusion/sqllogictest/test_files/array/array_empty.slt: ########## @@ -69,10 +69,8 @@ false #TODO: https://github.com/apache/datafusion/issues/7142 # empty scalar function #4 -#query B -#select empty(NULL); -#---- -#NULL +query error array_empty does not support type Null +select empty(NULL); Review Comment: its better for it to run to an error so when we fix it later we'll know to also fix this here ########## datafusion/sqllogictest/test_files/expr.slt: ########## @@ -1978,15 +1977,15 @@ query B select column1 <=> column2 from (VALUES (1, 1), (2, 3), (NULL, NULL)) as t; ---- true -false +false true # Sanity test - comparing <=> with equivalent expression query B -SELECT - (column1 <=> column2) = Review Comment: my editor was removing some trailing whitespace so decided to leave that little cleanup in as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
