mkleen commented on code in PR #23388:
URL: https://github.com/apache/datafusion/pull/23388#discussion_r3544315624
##########
datafusion/pruning/src/file_pruner.rs:
##########
@@ -143,8 +149,17 @@ impl FilePruner {
if !should_build {
return Ok(false);
}
+ // If there is no dynamic-filter-expression involved, convert constant
expression
+ // such as `a > 100` to `true`/`false` so `PruningPredicate` can use
to prune the file.
+ let predicate = if !self.tracking.contains_dynamic_filter() {
Review Comment:
This works, but i am not sure if this the best place to do it. The
expression will eventually end up in
https://github.com/apache/datafusion/blob/main/datafusion/pruning/src/pruning_predicate.rs#L476
but the `PhysicalExprSimplifier` won't be applied because it's not a dynamic
filter in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
