github-actions[bot] commented on PR #23390: URL: https://github.com/apache/datafusion/pull/23390#issuecomment-4916329155
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 100.568s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.035s] (current) Building datafusion v54.0.0 (baseline) Built [ 99.855s] (baseline) Parsing datafusion v54.0.0 (baseline) Parsed [ 0.033s] (baseline) Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.629s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 202.700s] datafusion Building datafusion-common v54.0.0 (current) Built [ 32.686s] (current) Parsing datafusion-common v54.0.0 (current) Parsed [ 0.060s] (current) Building datafusion-common v54.0.0 (baseline) Built [ 33.031s] (baseline) Parsing datafusion-common v54.0.0 (baseline) Parsed [ 0.061s] (baseline) Checking datafusion-common v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.732s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/constructible_struct_adds_field.ron Failed in: field ExecutionOptions.target_batch_size_bytes in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:723 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 67.573s] datafusion-common Building datafusion-datasource v54.0.0 (current) Built [ 37.167s] (current) Parsing datafusion-datasource v54.0.0 (current) Parsed [ 0.030s] (current) Building datafusion-datasource v54.0.0 (baseline) Built [ 36.866s] (baseline) Parsing datafusion-datasource v54.0.0 (baseline) Parsed [ 0.031s] (baseline) Checking datafusion-datasource v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.240s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 75.435s] datafusion-datasource Building datafusion-physical-plan v54.0.0 (current) Built [ 36.247s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.137s] (current) Building datafusion-physical-plan v54.0.0 (baseline) Built [ 35.877s] (baseline) Parsing datafusion-physical-plan v54.0.0 (baseline) Parsed [ 0.134s] (baseline) Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.552s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 74.119s] datafusion-physical-plan Building datafusion-sqllogictest v54.0.0 (current) Built [ 174.599s] (current) Parsing datafusion-sqllogictest v54.0.0 (current) Parsed [ 0.021s] (current) Building datafusion-sqllogictest v54.0.0 (baseline) Built [ 174.630s] (baseline) Parsing datafusion-sqllogictest v54.0.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-sqllogictest v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.085s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 352.445s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
