andygrove commented on PR #4861:
URL:
https://github.com/apache/datafusion-comet/pull/4861#issuecomment-4917015109
> Thanks @andygrove maybe we can rewrite into helper method
>
> ```
> def supportsMixedPartialFinal(agg: AggregateFunction): Boolean = agg match
{
> case _: Min | _: Max | _: BitAndAgg | _: BitOrAgg | _: BitXorAgg | _:
BloomFilterAgg =>
> true
> case s: Sum =>
> s.evalMode != EvalMode.TRY
> case a: Average =>
> !a.child.dataType.isInstanceOf[DecimalType]
> case _: Count =>
> false
> case _ =>
> false
> }
> ```
>
> instead of having T which is not always used, but it is not a blocker
It seems cleaner to have each serde object implement its own logic rather
than maintain in one place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
