kosiew commented on code in PR #23375:
URL: https://github.com/apache/datafusion/pull/23375#discussion_r3549331584
##########
datafusion/physical-expr/src/equivalence/properties/union.rs:
##########
@@ -899,6 +899,36 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_union_drops_unrepresentable_constant_value_after_schema_rewrite()
-> Result<()>
Review Comment:
Nice targeted test for the stale metadata state. As a follow-up, it may be
worth adding a higher-level regression test that builds the
filter/projection/union plan shape from the original issue and checks that
`UnionExec::try_new` or physical planning succeeds. That would help protect the
full path that produced the stale constant, not just the `calculate_union`
boundary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
