xudong963 commented on code in PR #23375:
URL: https://github.com/apache/datafusion/pull/23375#discussion_r3549390997
##########
datafusion/physical-expr/src/equivalence/properties/union.rs:
##########
@@ -899,6 +899,36 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_union_drops_unrepresentable_constant_value_after_schema_rewrite()
-> Result<()>
Review Comment:
Thanks, that makes sense. The current test intentionally targets the exact
stale-metadata boundary in `calculate_union`. I agree a higher-level regression
would be useful, especially if we can capture the original
filter/projection/union shape reliably. Since the reduced issue does not
include a concrete SQL repro and the normal projection path should drop
removed-column constants, I’ll keep this PR focused and consider adding a
`UnionExec::try_new`/planner-level regression as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
