gabotechs commented on code in PR #23189: URL: https://github.com/apache/datafusion/pull/23189#discussion_r3549863005
########## datafusion/datasource/src/file_scan_config/mod.rs: ########## Review Comment: I think the issue with claiming `Partitioning::Hash` goes even further: - One node can claim `Partitioning::Hash` and indeed be hash partitioned using `ahash` using the value "0" as seed as the hashing algorithm. - Another node can claim `Partitioning::Hash` and indeed be hash partitioned using `md5` as the hashing algorithm. - Another node can claim `Partitioning::Hash` and indeed be hash partitioned using `ahash` using the value "1" as seed as the hashing algorithm. - Another node can claim `Partitioning::Hash` and indeed be partitioned just on column values in an unspecified manner All of these situations are today represented as `Partitioning::Hash`, and DataFusion will think all of them are compatible when none of them are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
