hsiang-c commented on code in PR #4752:
URL: https://github.com/apache/datafusion-comet/pull/4752#discussion_r3553511939


##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -125,7 +125,7 @@ case class CometScanRule(session: SparkSession)
       case scan if !CometConf.COMET_NATIVE_SCAN_ENABLED.get(conf) =>
         withFallbackReason(scan, "Comet Scan is not enabled")
 
-      case scan if metadataCols(scan).nonEmpty =>
+      case scan: FileSourceScanExec if metadataCols(scan).nonEmpty =>

Review Comment:
   Maybe we can move it under the data source V1 branch?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to